drivers/scsi/ipr.c: In function `ipr_worker_thread': drivers/scsi/ipr.c:1825: wrong type argument to unary exclamation mark drivers/scsi/ipr.c: In function `ipr_read_dump': drivers/scsi/ipr.c:2426: wrong type argument to unary exclamation mark Cc: James Bottomley Cc: Brian King Signed-off-by: Andrew Morton --- 25-akpm/drivers/scsi/ipr.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff -puN drivers/scsi/ipr.c~ipr-build-fix drivers/scsi/ipr.c --- 25/drivers/scsi/ipr.c~ipr-build-fix 2004-09-02 22:48:36.314177520 -0700 +++ 25-akpm/drivers/scsi/ipr.c 2004-09-02 22:48:36.321176456 -0700 @@ -1822,10 +1822,11 @@ static void ipr_worker_thread(void *data if (ioa_cfg->sdt_state == GET_DUMP) { dump = ioa_cfg->dump; - if (!dump || !kref_get(&dump->kref)) { + if (!dump) { spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags); return; } + kref_get(&dump->kref); spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags); ipr_get_ioa_dump(ioa_cfg, dump); kref_put(&dump->kref, ipr_release_dump); @@ -2423,11 +2424,11 @@ static ssize_t ipr_read_dump(struct kobj spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags); dump = ioa_cfg->dump; - if (ioa_cfg->sdt_state != DUMP_OBTAINED || !dump || !kref_get(&dump->kref)) { + if (ioa_cfg->sdt_state != DUMP_OBTAINED || !dump) { spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags); return 0; } - + kref_get(&dump->kref); spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags); if (off > dump->driver_dump.hdr.len) { _