From: Mika Kukkonen CHECK drivers/pnp/pnpbios/core.c include/linux/pnpbios.h:144:5: warning: undefined preprocessor identifier 'needed' CC drivers/pnp/pnpbios/core.o CHECK drivers/pnp/pnpbios/bioscalls.c include/linux/pnpbios.h:144:5: warning: undefined preprocessor identifier 'needed' drivers/pnp/pnpbios/bioscalls.c:346:5: warning: undefined preprocessor identifier 'needed' drivers/pnp/pnpbios/bioscalls.c:361:5: warning: undefined preprocessor identifier 'needed' drivers/pnp/pnpbios/bioscalls.c:388:5: warning: undefined preprocessor identifier 'needed' drivers/pnp/pnpbios/bioscalls.c:427:5: warning: undefined preprocessor identifier 'needed' drivers/pnp/pnpbios/bioscalls.c:509:5: warning: undefined preprocessor identifier 'needed' CC drivers/pnp/pnpbios/bioscalls.o CHECK drivers/pnp/pnpbios/rsparser.c include/linux/pnpbios.h:144:5: warning: undefined preprocessor identifier 'needed' CC drivers/pnp/pnpbios/rsparser.o CHECK drivers/pnp/pnpbios/proc.c include/linux/pnpbios.h:144:5: warning: undefined preprocessor identifier 'needed' The fix is trivial, sparse wants the preprocessor symbol to be defined before use. There was a similar fix accepted by Linus couple weeks ago. Patch attached. Signed-off-by: Andrew Morton --- 25-akpm/include/linux/pnpbios.h | 1 + 1 files changed, 1 insertion(+) diff -puN include/linux/pnpbios.h~fix-sparse-warnings-in include/linux/pnpbios.h --- 25/include/linux/pnpbios.h~fix-sparse-warnings-in 2004-06-29 22:14:25.495524944 -0700 +++ 25-akpm/include/linux/pnpbios.h 2004-06-29 22:14:25.499524336 -0700 @@ -141,6 +141,7 @@ extern int pnp_bios_isapnp_config (struc extern int pnp_bios_escd_info (struct escd_info_struc *data); extern int pnp_bios_read_escd (char *data, u32 nvram_base); extern int pnp_bios_dock_station_info(struct pnp_docking_station_info *data); +#define needed 0 #if needed extern int pnp_bios_get_event (u16 *message); extern int pnp_bios_send_message (u16 message); _