From: Andrey Panin Signed-off-by: Andrew Morton --- 25-akpm/arch/i386/kernel/dmi_scan.c | 14 -------------- 25-akpm/drivers/acpi/sleep/main.c | 29 +++++++++++++++++++++++++++-- 2 files changed, 27 insertions(+), 16 deletions(-) diff -puN arch/i386/kernel/dmi_scan.c~dmi-port-acpi-sleep-quirk-to-new-dmi-probing arch/i386/kernel/dmi_scan.c --- 25/arch/i386/kernel/dmi_scan.c~dmi-port-acpi-sleep-quirk-to-new-dmi-probing Fri May 28 14:28:55 2004 +++ 25-akpm/arch/i386/kernel/dmi_scan.c Fri May 28 14:28:55 2004 @@ -193,17 +193,6 @@ static __init int broken_toshiba_keyboar return 0; } -/* - * Toshiba fails to preserve interrupts over S1 - */ - -static __init int init_ints_after_s1(struct dmi_system_id *d) -{ - printk(KERN_WARNING "Toshiba with broken S1 detected.\n"); - dmi_broken |= BROKEN_INIT_AFTER_S1; - return 0; -} - #ifdef CONFIG_ACPI_SLEEP static __init int reset_videomode_after_s3(struct dmi_system_id *d) { @@ -250,9 +239,6 @@ static __initdata struct dmi_system_id d { broken_toshiba_keyboard, "Toshiba Satellite 4030cdt", { /* Keyboard generates spurious repeats */ DMI_MATCH(DMI_PRODUCT_NAME, "S4030CDT/4.3"), } }, - { init_ints_after_s1, "Toshiba Satellite 4030cdt", { /* Reinitialization of 8259 is needed after S1 resume */ - DMI_MATCH(DMI_PRODUCT_NAME, "S4030CDT/4.3"), - } }, #ifdef CONFIG_ACPI_SLEEP { reset_videomode_after_s3, "Toshiba Satellite 4030cdt", { /* Reset video mode after returning from ACPI S3 sleep */ DMI_MATCH(DMI_PRODUCT_NAME, "S4030CDT/4.3"), diff -puN drivers/acpi/sleep/main.c~dmi-port-acpi-sleep-quirk-to-new-dmi-probing drivers/acpi/sleep/main.c --- 25/drivers/acpi/sleep/main.c~dmi-port-acpi-sleep-quirk-to-new-dmi-probing Fri May 28 14:28:55 2004 +++ 25-akpm/drivers/acpi/sleep/main.c Fri May 28 14:28:55 2004 @@ -10,6 +10,7 @@ #include #include +#include #include #include #include @@ -30,6 +31,8 @@ static u32 acpi_suspend_states[] = { [PM_SUSPEND_DISK] = ACPI_STATE_S4, }; +static int init_8259A_after_S1; + /** * acpi_pm_prepare - Do preliminary suspend work. * @state: suspend state we're entering. @@ -138,7 +141,7 @@ static int acpi_pm_finish(u32 state) /* reset firmware waking vector */ acpi_set_firmware_waking_vector((acpi_physical_address) 0); - if (dmi_broken & BROKEN_INIT_AFTER_S1) { + if (init_8259A_after_S1) { printk("Broken toshiba laptop -> kicking interrupts\n"); init_8259A(0); } @@ -159,17 +162,39 @@ int acpi_suspend(u32 acpi_state) return -EINVAL; } - static struct pm_ops acpi_pm_ops = { .prepare = acpi_pm_prepare, .enter = acpi_pm_enter, .finish = acpi_pm_finish, }; + +/* + * Toshiba fails to preserve interrupts over S1, reinitialization + * of 8259 is needed after S1 resume. + */ +static int __init init_ints_after_s1(struct dmi_system_id *d) +{ + printk(KERN_WARNING "%s with broken S1 detected.\n", d->ident); + init_8259A_after_S1 = 1; + return 0; +} + +static struct dmi_system_id __initdata acpisleep_dmi_table[] = { + { + .callback = init_ints_after_s1, + .ident = "Toshiba Satellite 4030cdt", + .matches = { DMI_MATCH(DMI_PRODUCT_NAME, "S4030CDT/4.3"), }, + }, + { }, +}; + static int __init acpi_sleep_init(void) { int i = 0; + dmi_check_system(acpisleep_dmi_table); + if (acpi_disabled) return 0; _