From: Oleg Drokin Since reiserfs_remount can be called without BKL held, we better take BKL in there. fs/reiserfs/super.c | 15 ++++++++++++--- 1 files changed, 12 insertions(+), 3 deletions(-) diff -puN fs/reiserfs/super.c~reiserfs-remount-locking-fix fs/reiserfs/super.c --- 25/fs/reiserfs/super.c~reiserfs-remount-locking-fix 2003-08-06 12:07:05.000000000 -0700 +++ 25-akpm/fs/reiserfs/super.c 2003-08-06 12:07:05.000000000 -0700 @@ -761,6 +761,7 @@ static int reiserfs_remount (struct supe if (!reiserfs_parse_options(s, arg, &mount_options, &blocks, NULL)) return -EINVAL; + reiserfs_write_lock(s); handle_attrs(s); /* Add options that are safe here */ @@ -778,17 +779,22 @@ static int reiserfs_remount (struct supe if(blocks) { int rc = reiserfs_resize(s, blocks); - if (rc != 0) + if (rc != 0) { + reiserfs_write_unlock(s); return rc; + } } if (*mount_flags & MS_RDONLY) { /* remount read-only */ - if (s->s_flags & MS_RDONLY) + if (s->s_flags & MS_RDONLY) { /* it is read-only already */ + reiserfs_write_unlock(s); return 0; + } /* try to remount file system with read-only permissions */ if (sb_umount_state(rs) == REISERFS_VALID_FS || REISERFS_SB(s)->s_mount_state != REISERFS_VALID_FS) { + reiserfs_write_unlock(s); return 0; } @@ -800,8 +806,10 @@ static int reiserfs_remount (struct supe s->s_dirt = 0; } else { /* remount read-write */ - if (!(s->s_flags & MS_RDONLY)) + if (!(s->s_flags & MS_RDONLY)) { + reiserfs_write_unlock(s); return 0; /* We are read-write already */ + } REISERFS_SB(s)->s_mount_state = sb_umount_state(rs) ; s->s_flags &= ~MS_RDONLY ; /* now it is safe to call journal_begin */ @@ -824,6 +832,7 @@ static int reiserfs_remount (struct supe if (!( *mount_flags & MS_RDONLY ) ) finish_unfinished( s ); + reiserfs_write_unlock(s); return 0; } _